Re: [PATCH 2/3] iscsi target: Set conn->sess to NULL when iscsi_login_set_conn_values fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 24, 2018 at 01:37:12PM -0500, Mike Christie wrote:
> Also, let idr_alloc return value through instead of replacing it with -ENOMEM,
> as it is already a negative value and caller checks sign, not exact value.

I bet it's less code to just return -ENOMEM in all situations instead of
making the compiler remember the return value from idr_alloc().  The
patch becomes smaller, at least ;-)




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux