On Thu, 2018-06-21 at 15:38 -0500, Mike Christie wrote:
> On 06/21/2018 03:25 PM, Bart Van Assche wrote:
> > > > * clearing it.
> > > > > > */
> > > > > > if (dev->dev_attrib.emulate_ua_intlck_ctrl != 0) {
> > > > > > + *key = UNIT_ATTENTION;
> > > >
> > > >
> > > > Is the key already set to UNIT_ATTENTION here?
> >
> > Good catch - that assignment is superfluous. But I would like to keep it
> > because I think it makes the core_scsi3_ua_for_check_condition() easy to
> > read. However, that assignment makes the following entry in sense_info_table[]
> > superfluous:
>
> If you keep it above then I think it would be good to add it below in
> the emulate_ua_intlck_ctrl=0 case:
>
> if (head) {
> *asc = ua->ua_asc;
> *ascq = ua->ua_ascq;
> head = 0;
> }
>
> so it is consistent.
OK, will do.
Bart.
��.n��������+%������w��{.n����j� ����{ay� ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��
