Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <Bart.VanAssche@xxxxxxx>
Subject: Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
From: "bigeasy@xxxxxxxxxxxxx" <bigeasy@xxxxxxxxxxxxx>
Date: Mon, 4 Jun 2018 09:16:06 +0200
Cc: "daniel@xxxxxxxxxx" <daniel@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "rostedt@xxxxxxxxxxx" <rostedt@xxxxxxxxxxx>, "torvalds@xxxxxxxxxxxxxxxxxxxx" <torvalds@xxxxxxxxxxxxxxxxxxxx>, "nab@xxxxxxxxxxxxxxx" <nab@xxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "acme@xxxxxxxxxx" <acme@xxxxxxxxxx>, "williams@xxxxxxxxxx" <williams@xxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "lclaudio@xxxxxxxxxx" <lclaudio@xxxxxxxxxx>, "target-devel@xxxxxxxxxxxxxxx" <target-devel@xxxxxxxxxxxxxxx>, "linux-rt-users@xxxxxxxxxxxxxxx" <linux-rt-users@xxxxxxxxxxxxxxx>
In-reply-to: <92633c987a900acf5e7defb481d347a9e5b1253d.camel@wdc.com>
References: <1521822325.2535.5.camel@wdc.com> <CA+55aFxVkuntSektVmwXktzvfEezdDTAM_zj4DJdp3qJxWf8aA@mail.gmail.com> <20180323171736.bcyi2oiolge4l6hl@linutronix.de> <20180326111359.180f1604@gandalf.local.home> <20180328101553.uduqsdbxwnxrhl7a@linutronix.de> <c9f5df1e54bb2bd8f3f0aef86a55deb11888a6a4.camel@wdc.com> <20180328151433.elhw6kgxdxq6fn6b@linutronix.de> <86c1243e-8733-c94d-d8ff-5c299b8266a6@wdc.com> <20180528143518.f46hyhi5r5jd3oxe@linutronix.de> <92633c987a900acf5e7defb481d347a9e5b1253d.camel@wdc.com>
User-agent: NeoMutt/20180512

On 2018-06-04 07:02:15 [+0000], Bart Van Assche wrote:
> 
> Would adding WARN_ON_ONCE(!irqs_disabled()) work fine with an RT kernel?

no, because the interrupts are not disabled at this point on RT.
Lockdep works fine on RT.

> Thanks,
> 
> Bart.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())
  - From: Bart Van Assche
- Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())
  - From: Linus Torvalds
- [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
  - From: bigeasy@xxxxxxxxxxxxx
- Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
  - From: Steven Rostedt
- Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
  - From: bigeasy@xxxxxxxxxxxxx
- Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
  - From: Bart Van Assche
- Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
  - From: bigeasy@xxxxxxxxxxxxx
- Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
  - From: Bart Van Assche
- Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
  - From: bigeasy@xxxxxxxxxxxxx
- Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
  - From: Bart Van Assche

Prev by Date: Re: [RFC PATCH] target: add emulate_pr backstore attr to toggle PR support
Next by Date: Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
Previous by thread: Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks
Next by thread: Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())
Index(es):
- Date
- Thread

[Index of Archives] [Linux SCSI] [Kernel Newbies] [Linux SCSI Target Infrastructure] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Device Mapper]