Re: [PATCH] target: move the rx hdr buffer out of the stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Dne 2.2.2018 v 15:15 Maurizio Lombardi napsal(a):
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -129,28 +129,41 @@ int iscsi_login_setup_crypto(struct iscsi_conn *conn)
>  	tfm = crypto_alloc_ahash("crc32c", 0, CRYPTO_ALG_ASYNC);
>  	if (IS_ERR(tfm)) {
>  		pr_err("crypto_alloc_ahash() failed\n");
> -		return -ENOMEM;
> +		goto err_exit;
> +	}
> +
> +	conn->conn_rx_buf = kmalloc(ISCSI_HDR_LEN, GFP_KERNEL);
> +	if (!conn->conn_rx_buf) {
> +		pr_err("kmalloc() failed for conn_rx_buf\n");
> +		goto err_free_ahash;
>  	}
>  

Probably conn_rx_buf should be initialized outside of iscsi_login_setup_crypto()
I will submit a V2 soon.

Maurizio
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux