On Wed, 6 Dec 2017 13:29:21 +0100, David Disseldorp wrote: > On Wed, 6 Dec 2017 04:33:16 +0000, Bart Van Assche wrote: > > > Although the patch itself looks fine to me: do we really need this kind of > > functionality in the kernel? Is it possible to implement the same functionality > > in user space? > > Thanks for the feedback, Bart and Johannes. This functionality could > be handled in user-space, but having the error reported when the > backstore is enabled, rather than when the backstore->control node is > setup makes it less than intuitive for targetcli, etc. > Having targetcli call ioctl(BLKROGET) prior to issuing the > backstore->control I/O would probably be a cleaner user-space option. FWIW, I've proposed targetcli changes to handle this via: https://github.com/open-iscsi/targetcli-fb/pull/97 This kernel change could be revisited in future if we decide to have LIO support obtaining iblock read-only status from underlying block devices. Cheers, David -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
