Re: [PATCH 00/20] tcmu update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/25/2017 11:47 AM, Mike Christie wrote:
> - Patch 5 - 18 fix bugs in tcmu's ring buffer code.
> - Patch 18 - 20 allow you to configure the size of the ring buffer

Hey Nick,

If you are out there, do not merge patches 5 - 20. I have a patchset
that will simplify things.

You should also drop

commit b8501553476c2eabbd15da79e152a84a9a67dc5a
Author: Xiubo Li <lixiubo@xxxxxxxxxxxxxxxxxxxx>
Date:   Wed Jul 12 15:16:07 2017 +0800

    tcmu: Add fifo type waiter list support to avoid starvation

https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&id=b8501553476c2eabbd15da79e152a84a9a67dc5a

and

commit 04229774f69250e0f7e63b4d1b50ba8371c9d165
Author: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date:   Tue Aug 1 23:09:17 2017 +0300

    tcmu: Oops in unmap_thread_fn()

    Calling list_del() on the iterator pointer in list_for_each_entry() will
    cause an oops.  We need to user the _safe() version for that.

https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git/commit/?h=for-next&id=04229774f69250e0f7e63b4d1b50ba8371c9d165

from your for-next branch. That first patch added several regressions
and the second patch is then not needed. My new patchset will fix the
starvation issue.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux