This patch adds a timeout for the completion of netlink command reply.
Current code waits for the netlink reply from userspace and the status
change, but it hangs forever when userspace failed to reply. To fix
this issue, this patch replace wait_for_completion with
wait_for_completion_timeout.
Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@xxxxxxxxx>
---
drivers/target/target_core_user.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 942d094269fb..284294340167 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1333,7 +1333,12 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev)
return 0;
pr_debug("sleeping for nl reply\n");
- wait_for_completion(&nl_cmd->complete);
+ ret = wait_for_completion_timeout(&nl_cmd->complete,
+ msecs_to_jiffies(3000));
+ if (!ret) {
+ printk(KERN_ERR "timeout waiting for nl reply from userspace\n");
+ return -ETIME;
+ }
spin_lock(&udev->nl_cmd_lock);
nl_cmd->cmd = TCMU_CMD_UNSPEC;
--
2.13.5
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
