I ran across a GPF after disabling demo-mode on an iSCSI target. The backtrace pointed to target_put_nacl(), which was called from transport_free_session(). A look at that function shows a pretty clear problem: 543 mutex_unlock(&se_tpg->acl_node_mutex); 544 545 if (se_nacl->dynamic_stop) 546 target_put_nacl(se_nacl); 547 548 target_put_nacl(se_nacl); 549 } So we make two calls to target_put_nacl() when se_nacl->dynamic_stop is true. This got introduced by 01d4d6735589 (target: Fix multi-session dynamic se_node_acl double free OOPs). It looks to me like we can just eliminate that first call, but I could easily be missing something. Can somebody with more familiarity in this area confirm? Thanks, -Justin -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
