On Fri, 2017-06-23 at 04:10 -0500, Mike Christie wrote: > The following patches are an attempt to replace the index counters > with IDAs per your review comment in the other thread. > > I was not sure if this is what you were requesting, so I am sending as a > RFC initially. One other question I had about this code is do we need > cyclic ID allocation? Did we only do this before because > it was simple or were we worried about apps not refreshing properly > when a device was readded with the same name. > > It seems like apps would always read the stats index file, then reference > other files, but I am was not sure. If we do not need cyclic ID allocation, > I will drop the first patch and not submit it to lkml when I repost > as a non RFC. > > These patches were made over Nick's for-next branch and my se_device idr > patches in the thread > "[PATCH V4 00/10] target/tcmu: make tcmu netlink ops sync". Hello Mike, Thanks for having implemented this. Although this is a behavior change, personally I'm fine with leaving out patch 1/4. I am aware that this means that IDs will be reused. Nick, do you want to comment on this patch series? Bart.-- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html