On Mon, 2017-07-03 at 01:26 -0500, Mike Christie wrote: > On 07/03/2017 12:32 AM, Nicholas A. Bellinger wrote: <SNIP> > > > > Applied as-is with the extra -v2 for patch #1. Thanks for fixing that > > up. ;) > > > > One concern though, patch #1 changes the configfs attribute name from > > 'path' to 'config', which will break existing userspace. > > > > So this isn't really an option, even though I agree the original name > > isn't particularly a good fit for what it actually does. > > > > That said, would you mind adding an incremental patch that re-adds the > > original 'path' attribute with existing behavior, and keeps 'config' > > with the new behavior..? > > > > I can, but the patch to add the tcmu_attr_dev_path was never in a > released kernel. It was just recently added in Bryant's patch: > > commit 0637d7f9698416bf745764edd4f6a20179c254ae > Author: Bryant G. Ly <bryantly@xxxxxxxxxxxxxxxxxx> > Date: Tue Jun 6 09:28:51 2017 -0500 > > tcmu: Make dev_config configurable > > that was merged the other week and only in your for-next branch. We do > not need to keep userspace compatibility with that branch do we? > > Whoops, my mistake. Apologies for the extra noise. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
