Re: [PATCH 12/12] target: rename target_free_device to target_destroy_device and cleanup callers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/21/2017 04:33 PM, Mike Christie wrote:
> This renames target_free_device to target_destroy_device
> to reflect most of the function is tearing down resources
> setup during target_configure_device.
> 
> I think it also makes goto/error handling nicer in that it follows
> other unwinding in the kernel where the goto takes you to a block of
> code that releases what was previously setup instead of having one mega
> function that can detect multiple states of setup.
> 
> We now know that if you have done target_alloc_device but configure failed
> or was not run you can just do target_free_device like is done in
> target_core_make_subdev and core_dev_setup_virtual_lun0.
> If target_configure device has been run successfully then you
> run target_destroy_device. We then do not need the DF_CONFIGURED
> check in what is now target_destroy_device.
> 
> Signed-off-by: Mike Christie <mchristi@xxxxxxxxxx>


Bart, ignore this patch. It has a bug.

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux