Hey Mike, On Wed, 2017-05-31 at 15:52 -0500, Mike Christie wrote: > Patches 1 - 6 fix the issue where tcmu's sense and scsi status was > getting dropped and replaced with a generic LUN communication error. > > Patches 7 - 13 is just an attempt at simplifying the completion path > (if correct, patch 9 and 11 are actauall fixes and I will order/separate > when I repost in a non RFC patchset). > > I am still testing the patches, but wanted to get any input people had. After a first pass, I'd say this looks good. The only thing that needs alot of review and testing is #12, specifically around how the various COMPARE_AND_WRITE cases work. Those took a while to get right, although all of the bug-fixes I've hit using the functional equivalent of patch #6 (in out of tree code) to allow non SAM_STAT_GOOD 'success' via target_complete_ok_work() with COMPARE_AND_WRITE have been addressed. That said, I'm ready to merge the rest of the series ASAP once you're ready. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
