Re: [PATCH] improve some error logging in rbd.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/04/2017 03:17 PM, David Butterfield wrote:
> Signed-off-by: David Butterfield <dab21774@xxxxxxxxx>
> ---
>  rbd.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/rbd.c b/rbd.c
> index 8f78e54..852338d 100644
> --- a/rbd.c
> +++ b/rbd.c
> @@ -427,18 +427,20 @@ static int tcmu_rbd_open(struct tcmu_device *dev)
>  
>  	pool = strtok(config, "/");
>  	if (!pool) {
> +		tcmu_dev_err(dev, "Could not get pool name\n");
>  		ret = -EINVAL;
>  		goto free_state;
>  	}
>  	state->pool_name = strdup(pool);
>  	if (!state->pool_name) {
>  		ret = -ENOMEM;
> -		tcmu_dev_err(dev, "Could copy pool name\n");
> +		tcmu_dev_err(dev, "Could not copy pool name\n");
>  		goto free_state;
>  	}
>  
>  	name = strtok(NULL, "/");
>  	if (!name) {
> +		tcmu_dev_err(dev, "Could not get image name\n");
>  		ret = -EINVAL;
>  		goto free_state;
>  	}
> @@ -446,7 +448,7 @@ static int tcmu_rbd_open(struct tcmu_device *dev)
>  	state->image_name = strdup(name);
>  	if (!state->image_name) {
>  		ret = -ENOMEM;
> -		tcmu_dev_err(dev, "Could copy image name\n");
> +		tcmu_dev_err(dev, "Could not copy image name\n");
>  		goto free_state;
>  	}
>  

What the heck happend. Merged. Thanks!

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux