Re: [PATCH 5/6] target/iscsi: Introduce iscsit_get_cmd() and iscsit_put_cmd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-03-30 at 10:12 -0700, Bart Van Assche wrote:
> Keep track in .refcnt of whether or not target_put_sess_cmd() has
> already been called.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> ---
>  drivers/target/iscsi/cxgbit/cxgbit_target.c  |  2 +-
>  drivers/target/iscsi/iscsi_target.c          | 16 ++++++-------
>  drivers/target/iscsi/iscsi_target_configfs.c |  4 +++-
>  drivers/target/iscsi/iscsi_target_util.c     | 35 +++++++++++++++++++++++++++-
>  include/target/iscsi/iscsi_target_core.h     |  1 +
>  include/target/iscsi/iscsi_transport.h       |  2 ++
>  6 files changed, 49 insertions(+), 11 deletions(-)
> 

Given the earlier incorrect assumptions wrt transport_generic_free_cmd()
return value during CMD_T_ABORTED, it's completely unnecessary to
introduce a driver specific reference count.

Dropping this patch.

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux