On Thu, 2017-03-30 at 10:12 -0700, Bart Van Assche wrote: > Initialize .data_direction to DMA_NONE in iscsit_allocate_cmd() > such that the second argument of __iscsit_free_cmd() can be left > out. Note: this patch causes the first part of __iscsit_free_cmd() > to be skipped for TMFs. That's fine since no data segments are > associated with TMFs. > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> > --- > drivers/target/iscsi/iscsi_target.c | 4 +--- > drivers/target/iscsi/iscsi_target_util.c | 26 ++++++++++++-------------- > drivers/target/iscsi/iscsi_target_util.h | 2 +- > 3 files changed, 14 insertions(+), 18 deletions(-) > This patch looks fine, but needs to be updated to apply atop what's in mainline queue for target-pending/master wrt iscsit_free_cmd(): iscsi-target: Fix TMR reference leak during session shutdown https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git/commit/?id=efb2ea770bb3b0f40007530bc8b0c22f36e1c5eb -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
