Hey MNC, Apologies for the delayed follow up on this. Comments below. On Thu, 2017-03-09 at 02:42 -0600, Mike Christie wrote: > This patchset made over target-pending master fixes the following bugs > added in the last patches: > Thanks, I ended up just dropping the original patch to remove cmd_time_out, and the subsequent patch to revert it. > 1. Make tcmu cmd timeout configurable instead of removing it. > I ended up adding this in tcmu_set_configfs_dev_params instead of > tb_dev_attrib_attrs because this is how we are setting other > tcmu initialization settings. If you prefer tb_dev_attrib_attrs I will > change it. > So having the hw_block_size and hw_max_sectors set via tcmu_set_configfs_dev_params() is OK, because these are read-only attributes from the perspective of tb_dev_attrib_attrs. Since cmd_time_out is intended to be a RW attribute this should really go under tb_dev_attrib_attrs as a backend specific attribute, and so it shows up in targetcli, et al. I've got a patch for this, and will comment inline in patch #4. > 2. I completely goofed in tcmu_show_configfs_dev_params for the > hw max sectors patch. > Squashed into the original patch. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
