On Mon, 2017-03-06 at 11:42 -0600, Mike Christie wrote: > On 03/01/2017 11:14 PM, Mike Christie wrote: > > This patch removes the tcmu the cmd timeout code. Like with the core > > target_core_tmr.c code, the kernel does not know the state of the command > > or implemenation details of the device, so it might not be safe to just > > return the command to the initiator for a possible retry. > > > > Signed-off-by: Mike Christie <mchristi@xxxxxxxxxx> > > --- > > drivers/target/target_core_user.c | 83 +-------------------------------------- > > 1 file changed, 1 insertion(+), 82 deletions(-) > > > > diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c > > index 266dc82..c621f1a 100644 > > --- a/drivers/target/target_core_user.c > > +++ b/drivers/target/target_core_user.c > > @@ -129,11 +129,6 @@ struct tcmu_cmd { > > /* Can't use se_cmd when cleaning up expired cmds, because if > > cmd has been completed then accessing se_cmd is off limits */ > > DECLARE_BITMAP(data_bitmap, DATA_BLOCK_BITS); > > - > > - unsigned long deadline; > > - > > Hey Nick, > > I missed deleting the timer_list struct which is now not used. The > attached version 2 of the patch fixes that. Updated version -v2 applied to target-pending/master. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html