Re: [PATCH v4 23/37] target: Remove the write_pending_status() callback function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-02-09 at 22:37 +0000, Bart Van Assche wrote:
> On Thu, 2017-02-09 at 02:59 -0800, Nicholas A. Bellinger wrote:
> > Yeah, you can't randomly remove this code.
> 
> I will ignore this feedback since I have already explained in a previous
> patch that you have misunderstood how the new approach to abort commands
> works. Additionally, the mere existence of the write_pending_status()
> callback function is a design bug. It is impossible to check whether or
> not a write is pending without protecting that call with some kind of
> locking. That by itself is more than sufficient as a reason to remove this
> callback function.
> 

Incorrect.

qla2xxx must wait until the CTIO hw completion for the outstanding WRITE
transfer is finished, before the abort can continue processing.

This change and the previous changes ignore all of that.



--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux