On Wed, 2017-02-08 at 14:24 -0800, Bart Van Assche wrote:
> The *aborted and *tas variables are set by
> __transport_wait_for_tasks() but the value that is set is ignored
> by all callers due to previous patches. Hence remove the code that
> sets these variables.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
> Cc: Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: David Disseldorp <ddiss@xxxxxxx>
> ---
> drivers/target/target_core_transport.c | 30 ++++++++++--------------------
> 1 file changed, 10 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 43b49f87dd22..f6d38eba139e 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -2714,9 +2711,8 @@ void transport_clear_lun_ref(struct se_lun *lun)
> wait_for_completion(&lun->lun_ref_comp);
> }
>
> -static bool
> -__transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop,
> - bool *aborted, bool *tas, unsigned long *flags)
> +static bool __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop,
> + unsigned long *flags)
> __releases(&cmd->t_state_lock)
> __acquires(&cmd->t_state_lock)
> {
> @@ -2727,12 +2723,6 @@ __transport_wait_for_tasks(struct se_cmd *cmd, bool fabric_stop,
> if (fabric_stop)
> cmd->transport_state |= CMD_T_FABRIC_STOP;
>
> - if (cmd->transport_state & CMD_T_ABORTED)
> - *aborted = true;
> -
> - if (cmd->transport_state & CMD_T_TAS)
> - *tas = true;
> -
> if (!(cmd->se_cmd_flags & SCF_SE_LUN_CMD) &&
> !(cmd->se_cmd_flags & SCF_SCSI_TMR_CDB))
> return false;
Given that patch #18 doesn't address the second order issue where
session shutdown quiesce is occuring, while se_cmd decriptors are
actively in CMD_T_ABORTED state blocked waiting for backend I/O
completion, these two parameters are still required.
Dropping for now.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
