Hi Bart, So I'll be going through this entire series again with a fined tooth comb, top to bottom. Also, since I have close to zero confidence now after the obvious fatal issues with -v2 that the larger changes here have seen any type of rigorous Q/A and/or automation regression testing. That said, I'll go ahead and pick up the straight-forward changes for target-pending/for-next, and take the rest from there. Also, I'll be commenting on how the patch series itself is structured, etc. On Wed, 2017-02-08 at 14:24 -0800, Bart Van Assche wrote: > The most important changes in this patch series are: > * ABORT and LUN RESET handling is made synchronous. > * LUN lookup during ABORT handling is moved from the tcm_qla2xxx > driver into the target core. > * A deadlock in the XCOPY implementation has been fixed. > * The SCSI target core is simplified significantly. > This is far too vague a description for a significant set of changes like this, and far too significant a set of changes to include in one large patch series. Each of these bullets need to be it's own patch series. Also, the cover letter for each must include: If it's bug fix, describe the scenario when bug occurs, and how it manifests itself to users. Also describe how the bug has been addressed, and the possible approaches considered. If it's improvements, describe how it improves the code, and the testing that has been done to ensure it doesn't introduce regressions. For former, obviously this can be subjective. If it's simple or obvious cleanups, then it's much less important. > These patches have been tested against the iSCSI, ib_srpt and > tcm_qla2xxx target drivers. > This is also far to vague to be useful for significant changes. Instead, describe what you've tested, eg: - Was active I/O shutdown tested..? - Which TMRs and how many times they where triggered..? - How many volumes where tested concurrently..? - With what workload..? - With what types of hosts..? - How many nodes where used..? - And for how long did the test run..? > Please review the patches that have not yet been reviewed, I'll be responding inline to each patch, and giving a summary here at the end. Thanks. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
