On Wed, 2017-02-01 at 16:58 -0800, Bart Van Assche wrote:
> Ensure that complete(&nacl->acl_free_comp) is called before the
> node ACL is freed.
>
> Fixes: commit 21aaa23b0ebb ("target: Obtain se_node_acl->acl_kref during get_initiator_node_acl")
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Reviewed-by: Hannes Reiencke <hare@xxxxxxxx>
> Cc: Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Andy Grover <agrover@xxxxxxxxxx>
> Cc: David Disseldorp <ddiss@xxxxxxx>
> ---
> drivers/target/target_core_transport.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 1ded71800a2b..782b511c4f5f 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -568,6 +568,7 @@ void transport_deregister_session(struct se_session *se_sess)
> core_tpg_wait_for_nacl_pr_ref(se_nacl);
> core_free_device_list_for_node(se_nacl, se_tpg);
> se_sess->se_node_acl = NULL;
> + target_put_nacl(se_nacl);
> kfree(se_nacl);
> }
> pr_debug("TARGET_CORE[%s]: Deregistered fabric_sess\n",
Btw, this patch should be dropped.
The release of se_nacl memory needs to happen in the final
target_put_nacl() callback in order to address the root cause of the
long standing double free issue here:
https://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/commit/?id=01d4d673558985d9a118e1e05026633c3e2ade9b
That said, you'll want to drop this patch from your tree as I'll be
sending the v4.10 series to Linus soon.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
