On Mon, Feb 06, 2017 at 05:29:30PM +0000, Bart Van Assche wrote: > On Mon, 2017-02-06 at 01:14 -0800, Christoph Hellwig wrote: > > On Wed, Feb 01, 2017 at 04:58:33PM -0800, Bart Van Assche wrote: > > > Stop execution in the unlikely scenario that CMD_T_STOP has been > > > set for a command just after the command has been added to the > > > device command list and before .write_pending() is called. > > > > How could this happen? > > Hello Christoph, > > Since this call of transport_cmd_check_stop() occurs before command > execution starts and hence before CMD_T_ACTIVE is set > __transport_wait_for_tasks() cannot yet have set CMD_T_STOP. If you > want I can drop this patch. I think checking return values is always a good thing, so I like this patch in principle. Just my detector for how could this obvious bug ever be unnoticed was tripped off by it. So maybe just add a blurb that this is currently impossible, but checking is still sensible to the patch description. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
