On Mon, 2017-02-06 at 01:32 -0800, Christoph Hellwig wrote:
> > - int rc;
> > + int rc = -1;
>
> Instead of relying on -1 or memcmp return values in rc I'd suggest
> to use found_dev;
>
>
> *found_dev = NULL;
>
> ...
>
>
> if (!memcmp(&tmp_dev_wwn[0], dev_wwn, XCOPY_NAA_IEEE_REGEX_LEN)) {
> *found_dev = se_dev;
> target_get_device(se_dev);
> break;
> }
>
> ...
Hello Christoph,
I will make the proposed changes.
Bart.--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
