Re: [PATCH v2 13/36] target: Correct transport_wait_for_tasks() documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 01, 2017 at 04:58:30PM -0800, Bart Van Assche wrote:
> + * transport_wait_for_tasks - set CMD_T_STOP and wait for t_transport_stop_comp
> + * @cmd: command to wait on
>   *
> - * Called from frontend fabric context to wait for storage engine
> - * to pause and/or release frontend generated struct se_cmd.
> + * Returns immediately if CMD_T_ACTIVE has not been set. If CMD_T_ACTIVE has
> + * been set, sets the CMD_T_STOP flag, waits for t_transport_stop_comp and
> + * clears CMD_T_STOP and CMD_T_ACTIVE.
>   */
>  bool transport_wait_for_tasks(struct se_cmd *cmd)

I don't think this adds any value over reading the code just below
it.  I would suggest to just remove the comment.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux