On Tue, 2017-01-31 at 15:44 +0100, hch@xxxxxx wrote: > On Mon, Jan 30, 2017 at 09:42:50PM +0000, Bart Van Assche wrote: > > Maybe I overlooked something but I haven't found any clause in SAM-5 that > > specifies in which order task management functions should be executed. But > > I will add a comment in the code that explains this. > > It's just my unexplained change detector that went off. However if > we don't need the separate workqueue to start with it would be a good > preparational patch to remove it. > > The workqueue was added by me in 2012 and replaced a kthread - the > commit log mentions it uses a singlethreaded workqueue to keep the > semantics exactly the same as before. Hello Christoph, The SCSI target ALUA code uses tmr_wq to ensure that ALUA transitions are executed in the same order as the core_alua_do_transition_tg_pt() calls that triggered these transitions. So I'm not sure we can get rid of tmr_wq without rewriting the ALUA code. But I can modify the TMR code such that it always uses schedule_work() and hence doesn't need tmr_wq anymore. Bart.-- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
