On Thu, 2017-01-26 at 08:38 -0800, Christoph Hellwig wrote: > > +enum { > > + UNKNOWN_TMF = 0xff > > +}; > > + > > +static enum tcm_tmreq_table iscsit_convert_tmf(u8 iscsi_tmf) > > +{ > > + switch (iscsi_tmf) { > > + case ISCSI_TM_FUNC_ABORT_TASK: > > + return TMR_ABORT_TASK; > > Shouldn't the unknown value start with TMF_ and be added to the > enum in include/target/target_core_base.h? Hello Christoph, I will move the definition of the new constant. Thanks for the review. Bart.-- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html