On 01/26/2017 12:36 AM, Bart Van Assche wrote:
> Avoid that transport_cmd_check_stop_to_fabric() leaks a command
> reference if CMD_T_STOP has been set.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Andy Grover <agrover@xxxxxxxxxx>
> Cc: David Disseldorp <ddiss@xxxxxxx>
> ---
> drivers/target/target_core_transport.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index f7b31cade25e..df23883869fb 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -614,13 +614,11 @@ static int transport_cmd_check_stop(struct se_cmd *cmd, bool remove_from_lists,
> pr_debug("%s:%d CMD_T_STOP for ITT: 0x%08llx\n",
> __func__, __LINE__, cmd->tag);
>
> - spin_unlock_irqrestore(&cmd->t_state_lock, flags);
> -
> complete_all(&cmd->t_transport_stop_comp);
> - return 1;
> + } else {
> + cmd->transport_state &= ~CMD_T_ACTIVE;
> }
>
> - cmd->transport_state &= ~CMD_T_ACTIVE;
> if (remove_from_lists) {
> /*
> * Some fabric modules like tcm_loop can release
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
