Re: [PATCH 12/34] target: Remove an overly chatty debug message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/26/2017 12:36 AM, Bart Van Assche wrote:
> Enabling dynamic debug for the target_core_mod kernel module
> causes the system log to be spammed with the "Incremented ..."
> message. Hence remove it.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Andy Grover <agrover@xxxxxxxxxx>
> Cc: David Disseldorp <ddiss@xxxxxxx>
> ---
>  drivers/target/target_core_transport.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 6c451ea4f429..9881f0ac08d2 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1970,8 +1970,6 @@ static void transport_complete_task_attr(struct se_cmd *cmd)
>  	if (cmd->sam_task_attr == TCM_SIMPLE_TAG) {
>  		atomic_dec_mb(&dev->simple_cmds);
>  		dev->dev_cur_ordered_id++;
> -		pr_debug("Incremented dev->dev_cur_ordered_id: %u for SIMPLE\n",
> -			 dev->dev_cur_ordered_id);
>  	} else if (cmd->sam_task_attr == TCM_HEAD_TAG) {
>  		dev->dev_cur_ordered_id++;
>  		pr_debug("Incremented dev_cur_ordered_id: %u for HEAD_OF_QUEUE\n",
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@xxxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux