On 1/17/17, 10:02 AM, "Bart Van Assche" <bart.vanassche@xxxxxxxxxxx> wrote:
>Remove two set-but-not-used variables and avoid that the compiler
>warns about a third variable (rc).
>
>Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
>Cc: Quinn Tran <quinn.tran@xxxxxxxxxx>
>Cc: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
>Cc: Christoph Hellwig <hch@xxxxxx>
>---
> drivers/scsi/qla2xxx/qla_attr.c | 3 +--
> drivers/scsi/qla2xxx/qla_mbx.c | 2 --
> drivers/scsi/qla2xxx/qla_target.c | 3 +++
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
>index 47eb4d545d13..fefff506a08f 100644
>--- a/drivers/scsi/qla2xxx/qla_attr.c
>+++ b/drivers/scsi/qla2xxx/qla_attr.c
>@@ -753,7 +753,6 @@ qla2x00_issue_logo(struct file *filp, struct kobject *kobj,
> struct scsi_qla_host *vha = shost_priv(dev_to_shost(container_of(kobj,
> struct device, kobj)));
> int type;
>- int rval = 0;
> port_id_t did;
>
> type = simple_strtol(buf, NULL, 10);
>@@ -767,7 +766,7 @@ qla2x00_issue_logo(struct file *filp, struct kobject *kobj,
>
> ql_log(ql_log_info, vha, 0x70e4, "%s: %d\n", __func__, type);
>
>- rval = qla24xx_els_dcmd_iocb(vha, ELS_DCMD_LOGO, did);
>+ qla24xx_els_dcmd_iocb(vha, ELS_DCMD_LOGO, did);
> return count;
> }
>
>diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
>index b3a9f6a40a44..34de6d7e5262 100644
>--- a/drivers/scsi/qla2xxx/qla_mbx.c
>+++ b/drivers/scsi/qla2xxx/qla_mbx.c
>@@ -684,7 +684,6 @@ qla_set_exlogin_mem_cfg(scsi_qla_host_t *vha, dma_addr_t phys_addr)
> mbx_cmd_t mc;
> mbx_cmd_t *mcp = &mc;
> struct qla_hw_data *ha = vha->hw;
>- int configured_count;
>
> ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x111a,
> "Entered %s.\n", __func__);
>@@ -707,7 +706,6 @@ qla_set_exlogin_mem_cfg(scsi_qla_host_t *vha, dma_addr_t phys_addr)
> /*EMPTY*/
> ql_dbg(ql_dbg_mbx, vha, 0x111b, "Failed=%x.\n", rval);
> } else {
>- configured_count = mcp->mb[11];
> ql_dbg(ql_dbg_mbx + ql_dbg_verbose, vha, 0x118c,
> "Done %s.\n", __func__);
> }
>diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
>index bff9689f5ca9..7e0345d7a8d6 100644
>--- a/drivers/scsi/qla2xxx/qla_target.c
>+++ b/drivers/scsi/qla2xxx/qla_target.c
>@@ -3110,6 +3110,9 @@ static void qlt_send_term_imm_notif(struct scsi_qla_host *vha,
> #if 0 /* Todo */
> if (rc == -ENOMEM)
> qlt_alloc_qfull_cmd(vha, imm, 0, 0);
>+#else
>+ if (rc) {
>+ }
> #endif
> goto done;
> }
>--
>2.11.0
>
Looks Good.
Acked-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
>
��.n��������+%������w��{.n����j� ����{ay� ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��
