On Tue, Jan 10, 2017 at 10:50:18PM +0530, Bart Van Assche wrote:
> On Sat, 2017-01-07 at 22:09 +0530, Varun Prakash wrote:
> > +static int cxgbit_seq_pdu_inorder(struct cxgbit_sock *csk)
> > +{
> > + struct iscsi_conn *conn = csk->conn;
> > + struct iscsi_param *param;
> > +
> > + if (conn->login->leading_connection) {
> > + param = iscsi_find_param_from_key(DATASEQUENCEINORDER,
> > + conn->param_list);
> > + if (!param) {
> > + pr_err("param not found key %s\n", DATASEQUENCEINORDER);
> > + return -1;
> > + }
> > +
> > + if (strcmp(param->value, YES))
> > + return 1;
> > +
> > + param = iscsi_find_param_from_key(DATAPDUINORDER,
> > + conn->param_list);
> > + if (!param) {
> > + pr_err("param not found key %s\n", DATAPDUINORDER);
> > + return -1;
> > + }
> > +
> > + if (strcmp(param->value, YES))
> > + return 1;
> > +
> > + } else {
> > + if (!conn->sess->sess_ops->DataSequenceInOrder)
> > + return 1;
> > + if (!conn->sess->sess_ops->DataPDUInOrder)
> > + return 1;
> > + }
> > +
> > + return 0;
> > +}
>
> Please add a comment above cxgbit_seq_pdu_inorder() that explains the
> meaning of the -1, 0 and 1 return values.
Ok, I will add comment in v2.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
