On Sat, 2017-01-07 at 22:09 +0530, Varun Prakash wrote: > -int > -iscsit_check_dataout_hdr(struct iscsi_conn *conn, unsigned char *buf, > - struct iscsi_cmd **out_cmd) > +int __iscsit_check_dataout_hdr(struct iscsi_conn *conn, unsigned char *buf, > + struct iscsi_cmd *cmd, bool *success) > { Is there any reason that 'buf' is declared as 'unsigned char *' instead of 'void *' in the iscsit_check_dataout_hdr() and __iscsit_check_dataout_hdr() declarations? If the data type would be changed into 'void *' several casts could be left out. Bart.-- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html