Re: [PATCH 3/6] target: check XCOPY segment descriptor CSCD IDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +	if ((xop->stdi > 0x07FF) || (xop->dtdi > 0x07FF)) {

Please srop the pointless inner braces here.

Also maybe a #define for the symbolic constant would be nice, including
the reference you have in the patch description.

Otherwise this looks fine.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux