> + if ((xop->stdi > 0x07FF) || (xop->dtdi > 0x07FF)) { Please srop the pointless inner braces here. Also maybe a #define for the symbolic constant would be nice, including the reference you have in the patch description. Otherwise this looks fine. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html