On 11/18/16 4:40 PM, Bart Van Assche wrote:
On 11/18/2016 02:34 PM, Bart Van Assche wrote:
The build time of LIO can be reduced significantly by rearranging
#include directives. This patch series realizes that. The only change
compared to version 1 of this patch series is that a patch has been
added to avoid that building the ibmvscsi_tgt driver breaks on a PowerPC
system.
It would be appreciated if you would consider this patch series for
inclusion in the upstream kernel.
Note: a tree that includes this patch series was added several days
ago to Wu Fengguang's build bot system. No failures have been reported
so far.
Bart.
You will need the change below otherwise you will break tcmu from building.
I pulled in your changes and did a quick sudo make, and got:
drivers/target/target_core_user.c: In function ‘tcmu_flush_dcache_range’:
drivers/target/target_core_user.c:200:3: error: implicit declaration of
function ‘flush_dcache_page’ [-
Werror=implicit-function-declaration]
flush_dcache_page(virt_to_page(vaddr));
^
drivers/target/target_core_user.c: In function
‘alloc_and_scatter_data_area’:
drivers/target/target_core_user.c:270:10: error: implicit declaration of
function ‘kmap_atomic’ [-Werro
r=implicit-function-declaration]
from = kmap_atomic(sg_page(sg)) + sg->offset;
^
drivers/target/target_core_user.c:270:8: warning: assignment makes
pointer from integer without a cast
[-Wint-conversion]
from = kmap_atomic(sg_page(sg)) + sg->offset;
^
drivers/target/target_core_user.c:299:3: error: implicit declaration of
function ‘kunmap_atomic’ [-Werr
or=implicit-function-declaration]
kunmap_atomic(from - sg->offset);
^
drivers/target/target_core_user.c: In function ‘gather_data_area’:
drivers/target/target_core_user.c:320:6: warning: assignment makes
pointer from integer without a cast
[-Wint-conversion]
to = kmap_atomic(sg_page(sg)) + sg->offset;
^
Then I added the missing include in target_core_user.c and it seems to
have fixed it.
diff --git a/drivers/target/target_core_user.c
b/drivers/target/target_core_user.c
index 4756250..a8f63ee 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -27,6 +27,7 @@
#include <linux/uio_driver.h>
#include <linux/stringify.h>
#include <linux/bitops.h>
+#include <linux/highmem.h>
#include <net/genetlink.h>
#include <scsi/scsi_common.h>
#include <scsi/scsi_proto.h>
I think with this change you should be all set, you can add my sign offs
and tested by as long as the above
is fixed.
-Bryant
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
