Re: DIV0 in se_dev_align_max_sectors (drivers/target/target_core_device.c)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all (again),

So setting it to PAGE_SIZE caused it to panic the kernel on the server
that had the tape drives, but only during specific operations.

So I've revised and tested having it simply return zero.

And that works perfectly.

Possibly getting that added as a fix, if it doesn't already exist
would be great.

Regards

Malcolm Haak

On Mon, Oct 31, 2016 at 12:16 PM, Malcolm Haak <insanemal@xxxxxxxxx> wrote:
> Hi all,
>
> In my quest to get targetcli exporting mhvtl devices I ran into a dev0
> in se_dev_align_max_sectors.
>
> Now I am running kernel-3.10.0-229.el7 so it might be patched in newer
> kernels, but it seems that when using pscsi to export tape/changer
> scsi devices (being that they aren't block devices) it encounters a
> zero value for block_size.
>
> I've made my self a patch that sets a zero block size to PAGE_SIZE and
> it's working, but I'm not sure if this is the correct fix. (Patch is
> just a simple if block_size == 0 then block_size = PAGE_SIZE)
>
> So I guess I'm trying to a) find out if that is a valid fix and b)
> regardless if it is/isn't get a fix into mainline for other people to
> use.
>
>
> Thanks in advance
>
> Malcolm Haak
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux