Hello Bryant G. Ly,
The patch 88a678bbc34c: "ibmvscsis: Initial commit of IBM VSCSI Tgt
Driver" from Jun 28, 2016, leads to the following static checker
warning:
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:1748 ibmvscsis_mad()
warn: impossible condition '(() < 0) => (0-65535 < 0)'
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
1742 rc = ibmvscsis_copy_crq_packet(vscsi, cmd, crq);
1743 if (!rc) {
1744 mad = (struct mad_common *)&vio_iu(iue)->mad;
1745
1746 pr_debug("mad: type %d\n", be32_to_cpu(mad->type));
1747
1748 if (be16_to_cpu(mad->length) < 0) {
^^^^^^^^^^^^^^^^^^^^^^^^
be16_to_cpu() is unsigned. No idea what was intended.
1749 dev_err(&vscsi->dev, "mad: length is < 0\n");
1750 ibmvscsis_post_disconnect(vscsi,
1751 ERR_DISCONNECT_RECONNECT, 0);
1752 rc = SRP_VIOLATION;
1753 } else {
1754 rc = ibmvscsis_process_mad(vscsi, iue);
1755 }
1756
1757 pr_debug("mad: status %hd, rc %ld\n", be16_to_cpu(mad->status),
1758 rc);
1759
1760 if (!rc)
1761 ibmvscsis_send_mad_resp(vscsi, cmd, crq);
1762 } else {
1763 ibmvscsis_free_cmd_resources(vscsi, cmd);
1764 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
