Hi Christoph,
I believe I used the wrong git repo as my code base, I used lio-core,
which is out of date for alomost 4 years, that's the reason why it
doesn't apply to mainline.
I think you mean I can move the complete out of the if else
conditionals, right? I will send you another patch, would you please
help me check whether my next patch match your idea.
Thanks,
BR
Zhu Lingshan
On 08/31/2016 12:27 PM, Zhu Lingshan wrote:
Hi Christoph,
Thanks for your comment, It is OK for me to rework for the patch.
But I don't know whether I understand this right, do you mean we
should remove all these "session_wait_comp" complete /
wait_on_complete patterns?
That means remove "complete" in iscsit_close_connection, remove
"wait_on_complete" in iscsit_close_session and iscsit_free_session,
and remove "atomic_t sleep_on_sess_wait_comp" related operations
according to it.
If I understand this right, I will rework on it carefully to analyze
the changes. If I am wrong, thanks for correcting me!
Thanks,
BR
Zhu Lingshan
On 08/31/2016 12:19 AM, Christoph Hellwig wrote:
This doesn't apply against mainline.
Also once all three branches near the end of iscsit_close_connection
contains this wakeup pattern it should be moved out of the conditionals.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
