> if ((command_size > (udev->cmdr_size / 2))
> - || data_length > udev->data_size)
> - pr_warn("TCMU: Request of size %zu/%zu may be too big for %u/%zu "
> + || data_length > udev->data_size) {
> + pr_warn("TCMU: Request of size %zu/%zu is too big for %u/%zu "
> "cmd/data ring buffers\n", command_size, data_length,
> udev->cmdr_size, udev->data_size);
> + return TCM_INVALID_CDB_FIELD;
> + }
And while I'm nit picking, normal Linux style would place the || at the
end of the first line.
Otherwise looks fine,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
