Hello Nick,
Quoting "Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx>:
Hi Bryant,
<SNIP>
>> Yes, it finally has been approved for me to post code on a public
>> github.
>> The link is: github.com/powervm/ibmvscsis
>>
>
> Great.
>
> I noticed https://github.com/powervm/ibmvscsis is stand-lone files, and
> not a clone of upstream linux.git.
>
> So you'll want to go ahead and create a fork from:
>
> https://github.com/torvalds/linux
>
> and then use target-pending/for-next (eg: the target code that will
> become v4.6-rc1) as a starting point for further ibmvscsis development.
>
> Also, please let me know if you have any questions wrt to git.
>
I will make these changes, but to clarify do you want us to carry a full
kernel repo upstream or can we just carry the target-pending?
It's useful to have a tree based on linux.git to PULL from for early
developments, but it's just for WIP code ahead of an initial upstream
driver merge.
I was wondering how you would like WIP code reviewed? I have created a pull
request against my own development branch which is a branch of for-next
with some initial changes. https://github.com/powervm/ibmvscsis/pull/5
Let me know if that is how you want code reviewed.
Also I have created Wiki's that contain config files for targetcli/WIP Log.
https://github.com/powervm/ibmvscsis/wiki
Lastly, I was wondering if we can remove handle_cmd_queue()? I think
it would be
better to re-write some of the queue handling so that we aren't spinning.
https://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/tree/drivers/scsi/ibmvscsi/ibmvscsis.c?h=for-next-vscsi#n1428
Also, do you know if host aka ibmvscsi is supposed to add something
into our queue
asking for what we have attached aka luns in this scenario? I would think
after login, they should add a queue to ask the target what we have?
Thanks,
Bryant
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
