On Tue, 2016-03-01 at 06:48 -0800, Christoph Hellwig wrote: > This really looks like an odd interface. I think everyone will > be much happpier in the long run if you do a generic offload interface > instead of special casing each possible driver. Yes, I think iscsit_transport_type should to be replaced with an enum defining three types: - TCP using Linux/NET + stateless hw offload - TCP using hw iscsi + network offload - RDMA using iser-target offload iscsit_transport_type was originally introduced to support TCP and SCTP network portal (which is still there btw), and since nobody cares about SCTP anymore, we can just drop it. Varun, let's go in this direction for -v2 code, and use this new enum for existing special cases that -v1 touches. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
