On 02/26/2016 11:43 AM, Sheng Yang wrote:
I thought we could allocate an exactly 1MB buffer, with your changes, no?
That warning message may need to be changed.
Yes we can, it make sense to remove the warning message.
Though I am not quite comfortable with one request fill the whole
buffer, because we would only able to handle one request with the
whole ring.
Like we discussed in
http://comments.gmane.org/gmane.linux.scsi.target.devel/11107 , we
should have a ring buffer fits all requests from upper layer.
I still don't have a good answer for what we should do here. If we want
to accommodate 1MB requests, and we want to have a reasonable queue
depth (64? 128?) then we would be vmalloc()ing more than 64MB for each
TCMU device. That seems too wasteful to me.
-- Andy
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
