On 02/25/2016 10:19 PM, Nicholas A. Bellinger wrote:
On Wed, 2016-02-24 at 13:17 +0800, ronghua li wrote:
I found that in iscsit_free_session,
iscsit_cause_connection_reinstatement was called and the input
parameter "sleep" is set to 1, I think it want to close these
connections one by one; but when iscsit_close_connection called, it
want to send SIGINT to all the connections in this session by
iscsit_stop_session(sess, 0, 0), is there any problem about this?
When I set the "sleep" parameter of
iscsit_cause_connection_reinstatement to “0” in iscsit_free_session,
or annotate the iscsit_stop_session call in iscsit_close_connection,
this crash will not happen.
This looks like the following bug that was fixed in July 2015:
iscsi-target: Fix use-after-free during TPG session shutdown
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/target?id=417c20a9b
Note this patch has a stable tag for v3.1+, but it's unclear if the
3.10.0-229.4.2.el7.x86_64 distro kernel you're running with contains the
bug-fix from upstream v3.10.y
Adding Andy CC' to confirm.
Alas, it doesn't. we rebased LIO to 4.0.y in and it never showed up in
that stable branch.
FYI, opened a bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1312456
Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
