maybe we can define it as:
static inline struct iser_rx_desc *
isert_rx(struct ib_cqe *rx_cqe)
{
return container_of(rx_cqe, struct iser_rx_desc, rx_cqe);
}
in the .h file ?
There is just a single use of this pattern, but if everyone prefers
the helper I can add it.
Sagi, any thoughts ?
+ struct iscsi_hdr *hdr = &rx_desc->iscsi_header;
struct iser_ctrl *iser_ctrl = &rx_desc->iser_header;
uint64_t read_va = 0, write_va = 0;
+ if (unlikely(wc->status != IB_WC_SUCCESS)) {
+ isert_print_wc(wc);
+ if (!--isert_conn->post_recv_buf_count)
maybe we can do isert_conn->post_recv_buf_count-- once at the beginning of
the function?
I'd rather not move the assignment around in this patch. If you
think this can sensible be done please send a follow up patch that
also explains why it's safe.
Ok.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
