Re: iSCSI login failure, possible race condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maged,

On Wed, 2016-02-03 at 12:08 +0000, Maged Mokhtar wrote:
> Hi Nick,
> 
> I used Wireshark and during target discovery the MS initiator sends 2 
> messages, the first gets a direct reply and the second through the 
> iscsi_target_sk_data_ready() callback. If the callback is received too 
> quickly, the LOGIN_FLAGS_READY is not set and no reply is sent to the 
> client for the second message. No further messages are send from either 
> end until the timeout is reached.. iscsi_target_sk_data_ready() is not 
> called. 
> 
>
> i fixed the problem in iscsi_target_nego.c  by moving the section that 
> checks the various LOGIN_FLAGS_* from the iscsi_target_sk_data_ready() 
> callback (atomic context) to the worker function 
> iscsi_target_do_login_rx() and in case  LOGIN_FLAGS_READY is not set, 
> sleep and test again then exit if still not set.

Thanks for the additional information here.

>  I can patch the changes but do not know how the process of whom/where
> to send to.
> 

Feel free to post your patch inline in a response, and we can review ->
apply as a bug-fix from there.

Thank you,

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux