On Mon, Jan 18, 2016 at 02:09:28PM -0600, mchristi@xxxxxxxxxx wrote: > From: Mike Christie <mchristi@xxxxxxxxxx> > > This patch has iblock and file backends pass the WRITE_SAME command to > the device for offloading if possible. It is similar to what is > done for UNMAP/discards, except that we export a large max write same > value to the initiator, and then rely on the block layer to > break it up into multiple requests if it cannot fit into one. I don't think doing this from the file driver is a good idea, if you want block device features use the iblock driver. I also don't think that anything issuing a block device command should be in target_core_sbc.c. The iblock changes look fine to me assuming the meat of the logic is moved to the iblock file as well. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html