On Wed, 2016-01-13 at 09:24 +0100, Christoph Hellwig wrote:
> On Tue, Jan 12, 2016 at 11:29:32PM -0800, Nicholas A. Bellinger wrote:
> > With this patch in place, this function is now also called by
> > core_tpg_set_initiator_node_queue_depth(), where previously it was
> > called only during target_alloc_node_acl().
> >
> > Might as well drop the ignored return while we're at it..
>
> Please add it to the patch description..
>
Done.
> > > > + continue;
> > > > + }
> > > > + target_put_session(sess);
> > > > + spin_lock_irqsave(&acl->nacl_sess_lock, flags);
> > > > }
> > > > + spin_unlock_irqrestore(&acl->nacl_sess_lock, flags);
> > >
> > > It seems at thus point there is no need for ->shutdown_session, it
> > > could be folded into ->close_session in a follow on patch.
> > >
> >
> > Not exactly.
> >
> > It's the final target_put_session() -> kref_put() upon
> > se_sess->sess_kref that invokes TFO->close_session().
>
> I know. But we are dropping the only long term held reference
> here, so the two are more or less equivalent.
No. If ->shutdown_session() succeeds, then target-core is
responsible for dropping both references.
> > > > -void target_get_session(struct se_session *se_sess)
> > > > +int target_get_session(struct se_session *se_sess)
> > > > {
> > > > - kref_get(&se_sess->sess_kref);
> > > > + return kref_get_unless_zero(&se_sess->sess_kref);
> > > > }
> > > > EXPORT_SYMBOL(target_get_session);
> > >
> > > I'd be much happier to have a separate prep patch for this..
> >
> > Since this will need to hit stable at some point, it likely needs to
> > stay with the original bug-fix.
>
> Please at least document it in the patch description. I'd still
> be happier to have the change to target_get_session as a preparatory
> patch, though.
Done.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
