Re: [PATCH 07/21] target: Fix a use-after-free in core_tpg_del_initiator_node_acl()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 06, 2016 at 03:20:24PM +0100, Bart Van Assche wrote:
> Eliminating "sess_list" seems like a good idea to me. But even if that list 
> is eliminated I think we still need the "kref2" mechanism that was 
> introduced in my patch. It is not known which function will be called first 
> - transport_deregister_session() (e.g. if ib_srpt receives a DREQ) or 
> core_tpg_del_initiator_node_acl(). But the target core session object has 
> to be kept until both functions have finished.

Indeed.  I though you were addressing a differnt race.  Can you rename
your new kref to something like "reap_ref" and write a better changelog
with the above information included?  Looks fine to me with those changes.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux