Re: iser-target: Add iSCSI Extensions for RDMA (iSER) target driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.
index 91eb22c..8954e12 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -356,7 +356,7 @@ isert_create_device_ib_res(struct isert_device *device)
         dev_attr = &device->dev_attr;
         ret = isert_query_device(device->ib_device, dev_attr);
         if (ret)
-               return ret;
+               goto out;

         /* asign function handlers */
         if (dev_attr->device_cap_flags & IB_DEVICE_MEM_MGT_EXTENSIONS &&
@@ -372,7 +372,7 @@ isert_create_device_ib_res(struct isert_device *device)

         ret = isert_alloc_comps(device, dev_attr);
         if (ret)
-               return ret;
+               goto out;

         device->pd = ib_alloc_pd(device->ib_device);
         if (IS_ERR(device->pd)) {
@@ -390,6 +390,9 @@ isert_create_device_ib_res(struct isert_device *device)

  out_cq:
         isert_free_comps(device);
+out:
+       if (ret > 0)
+               ret = -EINVAL;
         return ret;
  }

--

Looks fine,

Acked-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>

Thanks Nic, and thanks Dan for reporting!
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux