On Mon, 2016-01-04 at 10:38 -0800, Andy Grover wrote: > On 12/21/2015 11:49 PM, Christoph Hellwig wrote: > > On Mon, Dec 21, 2015 at 06:48:05PM -0800, Andy Grover wrote: > >> Add the 'tag' attribute to FC node ACLs. This is not used by kernel code, > >> but gives userspace a place to store a tag string. This is used to provide > >> support for initiator groups in targetcli. > >> > >> Just copy iscsi's implementation for tcm_fc. A few other fabrics that > >> support acls also need this, to be submitted separately after the holidays. > > > > Which is a pretty good argument that it should be provided by core code, > > and not the frontend drivers. > > Support for ACLs is an optional fabric feature, along with > discovery_auth, auth, nps (network portals), and tpgts. We could pull > these into core but then I think we'd be looking at adding feature flags > in struct target_core_fabric_ops, and more callbacks? I haven't really > scoped it out. > > Nick, what do you think? > If it's useful for existing user-space, I don't have an objection to applying this as-is to tcm_fc given it's small size, plus the other two fabric drivers (qla2xxx + ib_srpt) that support explicit NodeACLs. As HCH mentioned, it would be nice to make this generic for all drivers though.. In order for that to happen, we'd need (at least) need to share se_node_acl->acl_group configfs attributes between both core + fabric code. This was been briefly discussed during the great target configfs simplification of 2015, but IIRC there are still no cases where it's actually implemented yet. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
