All code that waits for this completion has been removed. Hence remove the completion object itself and also the code that sets this completion object. Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> Reviewed-by: Andy Grover <agrover@xxxxxxxxxx> Reviewed-by: Christoph Hellwig <hch@xxxxxx> Cc: Sagi Grimberg <sagig@xxxxxxxxxxxx> --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 8 +------- include/target/target_core_base.h | 1 - 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c index fb0a1bc..e65ba34 100644 --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c @@ -454,14 +454,8 @@ static void tcm_qla2xxx_handle_data_work(struct work_struct *work) cmd->cmd_flags |= BIT_11; cmd->vha->tgt_counters.qla_core_ret_ctio++; if (!cmd->write_data_transferred) { - /* - * Check if se_cmd has already been aborted via LUN_RESET, and - * waiting upon completion in tcm_qla2xxx_write_pending_status() - */ - if (cmd->se_cmd.transport_state & CMD_T_ABORTED) { - complete(&cmd->se_cmd.t_transport_stop_comp); + if (cmd->se_cmd.transport_state & CMD_T_ABORTED) return; - } if (cmd->se_cmd.pi_err) transport_generic_request_failure(&cmd->se_cmd, diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index e6571d5..9223b36 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h @@ -493,7 +493,6 @@ struct se_cmd { #define CMD_T_BUSY (1 << 9) spinlock_t t_state_lock; struct kref cmd_kref; - struct completion t_transport_stop_comp; struct completion finished; struct work_struct work; -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html