On 11/16/2015 6:37 PM, Sagi Grimberg wrote:
struct isert_conn *conn;
@@ -209,6 +210,7 @@ struct isert_conn {
struct work_struct release_work;
struct ib_recv_wr beacon;
bool logout_posted;
+ bool snd_w_inv;
};
We've gone into this aspect few times in the past... my preference
is to use bit flags so the code would look like
conn->flags |= ISER_CONN_SEND_W_INV
or
if (conn->flags & ISER_CONN_LOGOUT_POSTED)
And you didn't want to go that way... but you did used
bit-fields in other areas of the driver, right?
Lets use some sort of BF-ing (bit fields or bit flags) all over the place
and not introduce new booleans everywhere we go.
Doing this over and over makes our fast path structures to grow and
maybe start crossing cache-lines (did you check that?)
Or.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
